Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show vote metrics on dashboard #414

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Show vote metrics on dashboard #414

merged 5 commits into from
Jun 19, 2024

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Jun 12, 2024 •
edited by CoreumDevelopment
Loading

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner June 12, 2024 10:51
@wojtek-coreum wojtek-coreum requested review from masihyeganeh, dzmitryhil, miladz68 and ysv and removed request for a team June 12, 2024 10:51
dzmitryhil
dzmitryhil reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @masihyeganeh, @miladz68, and @ysv)

infra/apps/grafana/config/dashboards/bdjuno.json line 228 at r1 (raw file):

      "type": "barchart"
    },
    {

Could you please attach the screenshots?

miladz68
miladz68 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

masihyeganeh
masihyeganeh approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@wojtek-coreum wojtek-coreum merged commit 3b14cbb into master Jun 19, 2024
3 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/vote-metrics branch June 19, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzmitryhil dzmitryhil dzmitryhil left review comments

@miladz68 miladz68 miladz68 approved these changes

@masihyeganeh masihyeganeh masihyeganeh approved these changes

@ysv ysv Awaiting requested review from ysv ysv is a code owner automatically assigned from CoreumFoundation/team-blockchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-coreum @masihyeganeh @dzmitryhil @miladz68